Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: src/arm/debug-arm.cc

Issue 1218493005: Debugger: use debug break slots instead of ICs (except for calls). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) { 133 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) {
134 // Register state for CallICStub 134 // Register state for CallICStub
135 // ----------- S t a t e ------------- 135 // ----------- S t a t e -------------
136 // -- r1 : function 136 // -- r1 : function
137 // -- r3 : slot in feedback array (smi) 137 // -- r3 : slot in feedback array (smi)
138 // ----------------------------------- 138 // -----------------------------------
139 Generate_DebugBreakCallHelper(masm, r1.bit() | r3.bit(), 0); 139 Generate_DebugBreakCallHelper(masm, r1.bit() | r3.bit(), 0);
140 } 140 }
141 141
142 142
143 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
144 // Calling convention for IC load (from ic-arm.cc).
145 Register receiver = LoadDescriptor::ReceiverRegister();
146 Register name = LoadDescriptor::NameRegister();
147 Register slot = LoadDescriptor::SlotRegister();
148 RegList regs = receiver.bit() | name.bit() | slot.bit();
149 Generate_DebugBreakCallHelper(masm, regs, 0);
150 }
151
152
153 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
154 // Calling convention for IC store (from ic-arm.cc).
155 Register receiver = StoreDescriptor::ReceiverRegister();
156 Register name = StoreDescriptor::NameRegister();
157 Register value = StoreDescriptor::ValueRegister();
158 RegList regs = receiver.bit() | name.bit() | value.bit();
159 if (FLAG_vector_stores) {
160 regs |= VectorStoreICDescriptor::SlotRegister().bit();
161 }
162 Generate_DebugBreakCallHelper(masm, regs, 0);
163 }
164
165
166 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
167 // Calling convention for keyed IC load (from ic-arm.cc).
168 GenerateLoadICDebugBreak(masm);
169 }
170
171
172 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
173 // Calling convention for IC keyed store call (from ic-arm.cc).
174 GenerateStoreICDebugBreak(masm);
175 }
176
177
178 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
179 // Register state for CompareNil IC
180 // ----------- S t a t e -------------
181 // -- r0 : value
182 // -----------------------------------
183 Generate_DebugBreakCallHelper(masm, r0.bit(), 0);
184 }
185
186
187 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 143 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
188 // In places other than IC call sites it is expected that r0 is TOS which 144 // In places other than IC call sites it is expected that r0 is TOS which
189 // is an object - this is not generally the case so this should be used with 145 // is an object - this is not generally the case so this should be used with
190 // care. 146 // care.
191 Generate_DebugBreakCallHelper(masm, r0.bit(), 0); 147 Generate_DebugBreakCallHelper(masm, r0.bit(), 0);
192 } 148 }
193 149
194 150
195 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) { 151 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) {
196 // Register state for CallFunctionStub (from code-stubs-arm.cc). 152 // Register state for CallFunctionStub (from code-stubs-arm.cc).
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 239
284 240
285 const bool LiveEdit::kFrameDropperSupported = true; 241 const bool LiveEdit::kFrameDropperSupported = true;
286 242
287 #undef __ 243 #undef __
288 244
289 } // namespace internal 245 } // namespace internal
290 } // namespace v8 246 } // namespace v8
291 247
292 #endif // V8_TARGET_ARCH_ARM 248 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698