Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1218493003: PPC: [turbofan] Canonicalize return sequence for JSFunctions. (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Canonicalize return sequence for JSFunctions. Port 2b9112a578f66fc976557aededf3e203f48c395e Original commit message: This optimization is already implemented in fullcodegen, and basically makes sure that we do not unecessarily blow up the code with duplicated return sequences everywhere. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/3a1ef020cf8a5da2ec759a3bc630f3150d2490e4 Cr-Commit-Position: refs/heads/master@{#29333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-26 16:24:03 UTC) #2
donald.r.stence
lgtm
5 years, 6 months ago (2015-06-26 16:34:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218493003/1
5 years, 6 months ago (2015-06-26 17:04:12 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-26 17:04:13 UTC) #8
dstence
lgtm
5 years, 6 months ago (2015-06-26 17:09:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218493003/1
5 years, 6 months ago (2015-06-26 17:10:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 19:48:38 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 19:48:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a1ef020cf8a5da2ec759a3bc630f3150d2490e4
Cr-Commit-Position: refs/heads/master@{#29333}

Powered by Google App Engine
This is Rietveld 408576698