Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1218473003: [es6] Remove harmony-object-literal flag (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Remove harmony-object-literal flag And move tests to es6 directory BUG=v8:3516 LOG=N R=adamk@chromium.org, rossberg@chromium.org Committed: https://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375 Cr-Commit-Position: refs/heads/master@{#29334}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update description of harmony classes flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -580 lines) Patch
M src/bootstrapper.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +9 lines, -11 lines 0 comments Download
M src/parser.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/preparser.h View 6 chunks +4 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 45 chunks +35 lines, -92 lines 0 comments Download
A + test/mjsunit/es6/method-name-eval-arguments.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/object-literals-method.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/object-literals-property-shorthand.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/computed-property-names-object-literals-methods.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/computed-property-names-super.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/method-name-eval-arguments.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/mjsunit/harmony/object-literals-method.js View 1 chunk +0 lines, -314 lines 0 comments Download
D test/mjsunit/harmony/object-literals-property-shorthand.js View 1 chunk +0 lines, -73 lines 0 comments Download
D test/mjsunit/regress/regress-parse-object-literal.js View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-26 18:39:36 UTC) #1
adamk
lgtm https://codereview.chromium.org/1218473003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1218473003/diff/1/src/flag-definitions.h#newcode207 src/flag-definitions.h:207: V(harmony_classes, "harmony classes (implies object literal extension)") \ ...
5 years, 6 months ago (2015-06-26 18:48:32 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/1218473003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1218473003/diff/1/src/flag-definitions.h#newcode207 src/flag-definitions.h:207: V(harmony_classes, "harmony classes (implies object literal extension)") \ On ...
5 years, 6 months ago (2015-06-26 18:50:34 UTC) #3
arv (Not doing code reviews)
Update description of harmony classes flag
5 years, 6 months ago (2015-06-26 18:52:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218473003/20001
5 years, 6 months ago (2015-06-26 18:52:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 19:49:48 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 19:50:02 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47dd45c0ab585f7ea47b78f9e3a73c80e236d375
Cr-Commit-Position: refs/heads/master@{#29334}

Powered by Google App Engine
This is Rietveld 408576698