[turbofan] Also update the BranchHint when merging a BooleanNot.

[turbofan] Also update the BranchHint when merging a BooleanNot.

R=svenpanne@chromium.org

Committed: https://crrev.com/ce0431d665bdb079b16c3daa1c27cf00967f4aa9
Cr-Commit-Position: refs/heads/master@{#29324}

[Benedikt Meurer, 2015-06-26 11:27:51]

Hey Sven,

This was missing from the optimization. Obvious one.
Please take a look.

Thanks,
Benedikt

[Sven Panne, 2015-06-26 11:40:56]

LGTM with a nit.

https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operato...
File src/compiler/common-operator-reducer.cc (right):

https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operato...
src/compiler/common-operator-reducer.cc:102: // Negative the hint for {branch}.
Why do we need the switch at all? Isn't the simple one-liner

  node->set_op(common()->Branch(NegateBranch(BranchHintOf(node->op()));

enough for all cases? Then comment would be superfluous, BTW. If it's a
nano-optimization, please add a comment why it's necessary.

[Benedikt Meurer, 2015-06-26 11:43:40]

https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operato...
File src/compiler/common-operator-reducer.cc (right):

https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operato...
src/compiler/common-operator-reducer.cc:102: // Negative the hint for {branch}.
On 2015/06/26 11:40:56, Sven Panne wrote:
> Why do we need the switch at all? Isn't the simple one-liner
> 
>   node->set_op(common()->Branch(NegateBranch(BranchHintOf(node->op()));
> 
> enough for all cases? Then comment would be superfluous, BTW. If it's a
> nano-optimization, please add a comment why it's necessary.

Done.

[Benedikt Meurer, 2015-06-26 11:43:44]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-06-26 11:43:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
svenpanne@chromium.org
Link to the patchset: https://codereview.chromium.org/1218443002/#ps20001
(title: "Address nit.")

[commit-bot: I haz the power, 2015-06-26 11:43:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218443002/20001

[commit-bot: I haz the power, 2015-06-26 12:08:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-26 12:08:39]

Patchset 2 (id:??) landed as
https://crrev.com/ce0431d665bdb079b16c3daa1c27cf00967f4aa9
Cr-Commit-Position: refs/heads/master@{#29324}