Devtools Animations: Add buffer and effect selection to animation timeline

Devtools Animations: Add buffer and effect selection to animation timeline

This change allows the animation timeline UI to consume the visual effect
information from the backend models. It pulls these effects into a buffer
and allows each effect to be selected to be displayed in the timeline below.
The scrubber is also disabled for now in this change.

BUG=447083
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202665

[samli, 2015-07-07 08:09:40]

samli@chromium.org changed reviewers:
+ pfeldman@chromium.org

[samli, 2015-07-07 08:09:41]

PTAL.

Screenshot:
http://imgur.com/Y8cBUBR

[pfeldman, 2015-07-07 08:28:58]

Does this refer to the new timeline or an old timeline? Do you have a design doc
and an action plan on the new timeline that you could share?

[samli, 2015-07-07 08:50:06]

New timeline. The (product) design doc is pretty much the one I presented.
At the bottom I started simple implementation design/first steps action
plan but nothing detailed. I'm not sure if more detail is necessary,
doesn't seem too complex to me.

On Tue, 7 Jul 2015 18:28  <pfeldman@chromium.org> wrote:

> Does this refer to the new timeline or an old timeline? Do you have a
> design doc
> and an action plan on the new timeline that you could share?
>
> https://codereview.chromium.org/1218433007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[pfeldman, 2015-07-07 11:29:29]

On 2015/07/07 08:50:06, samli wrote:
> New timeline. The (product) design doc is pretty much the one I presented.
> At the bottom I started simple implementation design/first steps action
> plan but nothing detailed. I'm not sure if more detail is necessary,
> doesn't seem too complex to me.
> 
> On Tue, 7 Jul 2015 18:28  <mailto:pfeldman@chromium.org> wrote:
> 
> > Does this refer to the new timeline or an old timeline? Do you have a
> > design doc
> > and an action plan on the new timeline that you could share?
> >
> > https://codereview.chromium.org/1218433007/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

Could you share it with me? It is hard to assess what parts should stay vs what
is changing.

[samli, 2015-07-08 04:43:08]

On 2015/07/07 at 11:29:29, pfeldman wrote:
> On 2015/07/07 08:50:06, samli wrote:
> > New timeline. The (product) design doc is pretty much the one I presented.
> > At the bottom I started simple implementation design/first steps action
> > plan but nothing detailed. I'm not sure if more detail is necessary,
> > doesn't seem too complex to me.
> > 
> > On Tue, 7 Jul 2015 18:28  <mailto:pfeldman@chromium.org> wrote:
> > 
> > > Does this refer to the new timeline or an old timeline? Do you have a
> > > design doc
> > > and an action plan on the new timeline that you could share?
> > >
> > > https://codereview.chromium.org/1218433007/
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
email
> > to mailto:blink-reviews+unsubscribe@chromium.org.
> 
> Could you share it with me? It is hard to assess what parts should stay vs
what is changing.

go/animation-timeline
I've already removed the parts that need to be removed.

[pfeldman, 2015-07-08 15:30:28]

> go/animation-timeline
> I've already removed the parts that need to be removed.

I don't think it is ready.

[samli, 2015-07-09 02:02:11]

On 2015/07/08 at 15:30:28, pfeldman wrote:
> > go/animation-timeline
> > I've already removed the parts that need to be removed.
> 
> I don't think it is ready.

The proposal? The parts you commented on are unrelated to this patch entirely.
Screen capture of this patch: https://youtu.be/R4El5i9aMgU

[samli, 2015-09-09 23:41:50]

PTAL

[pfeldman, 2015-09-16 00:01:22]

On 2015/09/09 23:41:50, samli wrote:
> PTAL

Is this still relevant?

[samli, 2015-09-16 00:19:55]

On 2015/09/16 at 00:01:22, pfeldman wrote:
> On 2015/09/09 23:41:50, samli wrote:
> > PTAL
> 
> Is this still relevant?

Yes, PTAL

[pfeldman, 2015-09-19 00:17:40]

https://codereview.chromium.org/1218433007/diff/80001/Source/devtools/front_e...
File Source/devtools/front_end/animation/AnimationUI.js (right):

https://codereview.chromium.org/1218433007/diff/80001/Source/devtools/front_e...
Source/devtools/front_end/animation/AnimationUI.js:1: // Copyright (c) 2015 The
Chromium Authors. All rights reserved.
Could you split this into the move and refactoring? Otherwise it is hard to tell
what changed where.

[samli, 2015-09-22 22:15:08]

ping

[pfeldman, 2015-09-22 23:22:03]

lgtm

[samli, 2015-09-22 23:24:15]

The CQ bit was checked by samli@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:24:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218433007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1218433007/100001

[commit-bot: I haz the power, 2015-09-23 00:16:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 00:16:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[samli, 2015-09-23 01:46:04]

The CQ bit was checked by samli@chromium.org

[samli, 2015-09-23 01:46:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1218433007/#ps120001
(title: " Fix test")

[commit-bot: I haz the power, 2015-09-23 01:46:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218433007/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1218433007/120001

[commit-bot: I haz the power, 2015-09-23 05:55:19]

Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202665