Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1218403002: Increment descriptor array slack for prototypes by a constant rather than 50% (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Increment descriptor array slack for prototypes by a constant rather than 50% Additionally speed up instantiation of ObjectTemplates by preallocating enough space in the descriptor arrays BUG=v8:4184 LOG=n Committed: https://crrev.com/b0493ed16c0b363a0e92bf4a790d4fd851c74e70 Cr-Commit-Position: refs/heads/master@{#29468}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : More comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -48 lines) Patch
M src/api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/api-natives.cc View 1 2 7 chunks +38 lines, -37 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/transitions.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Toon Verwaest
ptal Should probably first create the map and afterwards the instance in api-natives.cc, but this ...
5 years, 5 months ago (2015-07-03 11:41:45 UTC) #2
Igor Sheludko
lgtm with a nit and suggestion: https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc File src/api-natives.cc (right): https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc#newcode150 src/api-natives.cc:150: PropertyKind kind = ...
5 years, 5 months ago (2015-07-03 13:56:40 UTC) #3
Igor Sheludko
lgtm with a nit and suggestion:
5 years, 5 months ago (2015-07-03 13:56:41 UTC) #4
Toon Verwaest
Addressed comments
5 years, 5 months ago (2015-07-03 14:29:05 UTC) #5
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-03 14:35:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218403002/40001
5 years, 5 months ago (2015-07-03 14:41:54 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-03 15:06:46 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 15:07:00 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0493ed16c0b363a0e92bf4a790d4fd851c74e70
Cr-Commit-Position: refs/heads/master@{#29468}

Powered by Google App Engine
This is Rietveld 408576698