Issue 12184029: Make pnacl install on demand when it is not already installed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12184029: Make pnacl install on demand when it is not already installed. (Closed)

Created:
7 years, 10 months ago by jvoung (off chromium)

Modified:
7 years, 5 months ago

Reviewers:

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make pnacl install on demand when it is not already installed. There is no UI yet, but it should install within a few seconds, then proceed to run a pnacl application. If there is an error, or the install times out then we will see an error in the Javascript console, emitted by the pnacl_coordinator. BUG=107438

Patch Set 1 #

Patch Set 2 : without notification service #

Patch Set 3 : document and fix timeout #

Patch Set 4 : forward decl #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -51 lines)			Patch
M	chrome/browser/component_updater/component_updater_service.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_service.cc	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.h	View	1 2 3	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.cc	View	1 2	12 chunks	+145 lines, -46 lines	0 comments	Download
M	chrome/browser/nacl_host/pnacl_file_host.cc	View	1	2 chunks	+56 lines, -5 lines	0 comments	Download