Set unswept free bytes for concurent sweeper.

Set unswept free bytes for concurent sweeper.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13776

[Hannes Payer (out of office), 2013-02-05 13:00:47]

On 2013/02/04 17:00:30, Hannes Payer wrote:

I would prefer to get rid of unswept_free_bytes_.

[Michael Starzinger, 2013-02-28 13:09:52]

Sorry for the long delay. Almost looking good.

https://codereview.chromium.org/12184016/diff/8001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/12184016/diff/8001/src/mark-compact.cc#newcod...
src/mark-compact.cc:526:
heap()->paged_space(OLD_POINTER_SPACE)->ResetUnsweptFreeBytes();
This requires rebasing, but I agree that WaitUntilSweepingCompleted() is the
right place for the reset.

https://codereview.chromium.org/12184016/diff/8001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/12184016/diff/8001/src/spaces.h#newcode1754
src/spaces.h:1754: void DecreaseUnsweptFreeBytes(int by) {
Let's rename this to DecrementUnsweptFreeBytes() which is in line with the other
names.

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.cc
File src/sweeper-thread.cc (right):

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.cc#newc...
src/sweeper-thread.cc:82: space->DecreaseUnsweptFreeBytes(free_bytes);
As discussed offline: Let's move both (AddToAccountingStats and
DecreaseUnsweptFreeBytes) into
MarkCompactCollector::StealMemoryFromSweeperThreads, it should be part the
mark-compact.cc file.

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.h
File src/sweeper-thread.h (right):

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.h#newco...
src/sweeper-thread.h:65: intptr_t StealMemory(PagedSpace* space, FreeList*
free_list);
This declaration is obsolete after addressing the comment in the
sweeper-thread.cc file.

[Hannes Payer (out of office), 2013-02-28 14:42:34]

https://codereview.chromium.org/12184016/diff/8001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/12184016/diff/8001/src/mark-compact.cc#newcod...
src/mark-compact.cc:526:
heap()->paged_space(OLD_POINTER_SPACE)->ResetUnsweptFreeBytes();
On 2013/02/28 13:09:52, Michael Starzinger wrote:
> This requires rebasing, but I agree that WaitUntilSweepingCompleted() is the
> right place for the reset.

Done.

https://codereview.chromium.org/12184016/diff/8001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/12184016/diff/8001/src/spaces.h#newcode1754
src/spaces.h:1754: void DecreaseUnsweptFreeBytes(int by) {
On 2013/02/28 13:09:52, Michael Starzinger wrote:
> Let's rename this to DecrementUnsweptFreeBytes() which is in line with the
other
> names.

Done.

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.cc
File src/sweeper-thread.cc (right):

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.cc#newc...
src/sweeper-thread.cc:82: space->DecreaseUnsweptFreeBytes(free_bytes);
On 2013/02/28 13:09:52, Michael Starzinger wrote:
> As discussed offline: Let's move both (AddToAccountingStats and
> DecreaseUnsweptFreeBytes) into
> MarkCompactCollector::StealMemoryFromSweeperThreads, it should be part the
> mark-compact.cc file.

Done.

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.h
File src/sweeper-thread.h (right):

https://codereview.chromium.org/12184016/diff/8001/src/sweeper-thread.h#newco...
src/sweeper-thread.h:65: intptr_t StealMemory(PagedSpace* space, FreeList*
free_list);
On 2013/02/28 13:09:52, Michael Starzinger wrote:
> This declaration is obsolete after addressing the comment in the
> sweeper-thread.cc file.

Done.

[Michael Starzinger, 2013-02-28 14:49:53]

LGTM with one final nit.

https://codereview.chromium.org/12184016/diff/14001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/12184016/diff/14001/src/spaces.h#newcode1795
src/spaces.h:1795: void AddToAccountingStats(intptr_t bytes) {
Since this is no longer protected, let's move it up where the other stats
functions are (e.g. to below ClearStats) and add a short comment about it's
semantics.

[Hannes Payer (out of office), 2013-02-28 15:07:15]

https://codereview.chromium.org/12184016/diff/14001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/12184016/diff/14001/src/spaces.h#newcode1795
src/spaces.h:1795: void AddToAccountingStats(intptr_t bytes) {
On 2013/02/28 14:49:53, Michael Starzinger wrote:
> Since this is no longer protected, let's move it up where the other stats
> functions are (e.g. to below ClearStats) and add a short comment about it's
> semantics.

Done.

[Hannes Payer (out of office), 2013-02-28 15:07:34]

Committed manually as r13776 (presubmit successful).