Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 121833002: [MIPS] Add support for thread_suspension test (Closed)

Created:
6 years, 12 months ago by petarj
Modified:
6 years, 12 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Add support for thread_suspension test This change: - implements NaClSignalContextUnsetClobberedRegisters() for MIPS, - modifies Unwind for thread suspension to match what is needed for MIPS, - adds MIPS-arch specific parts in suspend_test_guest.c and suspend_test_host.c. BUG= run_thread_suspension_test fails for MIPS TEST= run run_thread_suspension_test on MIPS-board Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=12571

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove strayed backslashes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -35 lines) Patch
M src/trusted/service_runtime/arch/mips/nacl_syscall.S View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/arch/mips/sel_rt.c View 1 chunk +24 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/thread_suspension_unwind.c View 5 chunks +24 lines, -26 lines 0 comments Download
M tests/thread_suspension/suspend_test_guest.c View 4 chunks +35 lines, -0 lines 0 comments Download
M tests/thread_suspension/suspend_test_host.c View 1 2 chunks +33 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
petarj
PTAL.
6 years, 12 months ago (2013-12-27 20:14:23 UTC) #1
Mark Seaborn
LGTM. I would recommend enabling tests/signal_handler_single_step/ for MIPS as well. tests/thread_suspension's testing of suspending in ...
6 years, 12 months ago (2013-12-27 21:09:16 UTC) #2
petarj
https://chromiumcodereview.appspot.com/121833002/diff/1/tests/thread_suspension/suspend_test_host.c File tests/thread_suspension/suspend_test_host.c (right): https://chromiumcodereview.appspot.com/121833002/diff/1/tests/thread_suspension/suspend_test_host.c#newcode343 tests/thread_suspension/suspend_test_host.c:343: /* Skip setting zero register because it's read-only. */ ...
6 years, 12 months ago (2013-12-27 23:03:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/121833002/240001
6 years, 12 months ago (2013-12-27 23:04:03 UTC) #4
commit-bot: I haz the power
6 years, 12 months ago (2013-12-28 00:32:09 UTC) #5
Message was sent while issue was closed.
Change committed as 12571

Powered by Google App Engine
This is Rietveld 408576698