Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1218323002: Hook up test runner to new layout_test_html_viewer (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
jam, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up test runner to new layout_test_html_viewer Use --content-handlers=text/html,mojo:layout_test_html_viewer to test BUG=478250 R=sky@chromium.org Committed: https://crrev.com/34415e5c0318b11014a869176e07f69a0b76699d Cr-Commit-Position: refs/heads/master@{#338260}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 6

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+650 lines, -126 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 4 chunks +48 lines, -11 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M components/html_viewer/content_handler_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/html_viewer/html_document.h View 1 2 2 chunks +15 lines, -12 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.h View 4 chunks +10 lines, -1 line 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 5 chunks +12 lines, -3 lines 0 comments Download
M components/html_viewer/html_viewer.h View 1 chunk +7 lines, -1 line 0 comments Download
A components/html_viewer/layout_test_content_handler_impl.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A components/html_viewer/layout_test_content_handler_impl.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download
A components/html_viewer/layout_test_html_viewer.h View 1 chunk +40 lines, -0 lines 0 comments Download
A components/html_viewer/layout_test_html_viewer.cc View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A + components/html_viewer/layout_test_html_viewer_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/html_viewer/web_test_delegate_impl.h View 1 5 chunks +30 lines, -96 lines 0 comments Download
A components/html_viewer/web_test_delegate_impl.cc View 1 1 chunk +327 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
ptal can be used with mandoline --content-handler=text/html,layout_test_html_viewer
5 years, 5 months ago (2015-07-02 18:56:59 UTC) #1
jochen (gone - plz use gerrit)
+John as Scott is still out
5 years, 5 months ago (2015-07-08 21:04:18 UTC) #3
jam
lgtm https://codereview.chromium.org/1218323002/diff/20001/components/html_viewer/BUILD.gn File components/html_viewer/BUILD.gn (right): https://codereview.chromium.org/1218323002/diff/20001/components/html_viewer/BUILD.gn#newcode229 components/html_viewer/BUILD.gn:229: deps = [ many of these are shared. ...
5 years, 5 months ago (2015-07-09 16:48:27 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1218323002/diff/20001/components/html_viewer/BUILD.gn File components/html_viewer/BUILD.gn (right): https://codereview.chromium.org/1218323002/diff/20001/components/html_viewer/BUILD.gn#newcode229 components/html_viewer/BUILD.gn:229: deps = [ On 2015/07/09 at 16:48:27, jam wrote: ...
5 years, 5 months ago (2015-07-10 07:53:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218323002/40001
5 years, 5 months ago (2015-07-10 07:54:35 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-10 08:34:37 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 08:36:35 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/34415e5c0318b11014a869176e07f69a0b76699d
Cr-Commit-Position: refs/heads/master@{#338260}

Powered by Google App Engine
This is Rietveld 408576698