Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 12183030: Revert cross-origin auth prompt blocking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_dispatcher_host_impl.cc
===================================================================
--- content/browser/loader/resource_dispatcher_host_impl.cc (revision 180447)
+++ content/browser/loader/resource_dispatcher_host_impl.cc (working copy)
@@ -643,8 +643,9 @@
resource_type,
HTTP_AUTH_RESOURCE_LAST);
- if (resource_type == HTTP_AUTH_RESOURCE_BLOCKED_CROSS)
- return false;
+ // TODO(tsepez): someday return false on HTTP_AUTH_RESOURCE_BLOCKED_CROSS,
+ // but not now since the issues in http://crbug.com/174129 keep getting
Charlie Reis 2013/02/04 23:31:40 This took me a while to understand. Can you say a
+ // re-introduced.
}
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698