Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1218293020: Change the passwords warning on Mac as the Keychain becomes deprecated. (Closed)

Created:
5 years, 5 months ago by vasilii
Modified:
5 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the passwords warning on Mac as the Keychain becomes deprecated. BUG=466638 Committed: https://crrev.com/5fb5dc4138715d9d19d0ac67f44cbfbc59815eba Cr-Commit-Position: refs/heads/master@{#337811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vasilii
Hi Vaclav, please review the CL.
5 years, 5 months ago (2015-07-08 13:09:53 UTC) #2
vabr (Chromium)
Hi Vasilii, LGTM, thanks for thinking of these important details! Vaclav
5 years, 5 months ago (2015-07-08 13:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218293020/1
5 years, 5 months ago (2015-07-08 13:15:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 13:56:36 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 13:57:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fb5dc4138715d9d19d0ac67f44cbfbc59815eba
Cr-Commit-Position: refs/heads/master@{#337811}

Powered by Google App Engine
This is Rietveld 408576698