Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: Source/wtf/text/TextCodecICU.h

Issue 1218293019: Fix virtual/override/final usage in Source/wtf/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/wtf/Uint8ClampedArray.h ('k') | Source/wtf/text/TextCodecLatin1.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2007, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2007, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Alexey Proskuryakov <ap@nypop.com> 3 * Copyright (C) 2006 Alexey Proskuryakov <ap@nypop.com>
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 24 matching lines...) Expand all
35 35
36 namespace WTF { 36 namespace WTF {
37 37
38 class TextCodecInput; 38 class TextCodecInput;
39 39
40 class TextCodecICU final : public TextCodec { 40 class TextCodecICU final : public TextCodec {
41 public: 41 public:
42 static void registerEncodingNames(EncodingNameRegistrar); 42 static void registerEncodingNames(EncodingNameRegistrar);
43 static void registerCodecs(TextCodecRegistrar); 43 static void registerCodecs(TextCodecRegistrar);
44 44
45 virtual ~TextCodecICU(); 45 ~TextCodecICU() override;
46 46
47 private: 47 private:
48 TextCodecICU(const TextEncoding&); 48 TextCodecICU(const TextEncoding&);
49 static PassOwnPtr<TextCodec> create(const TextEncoding&, const void*); 49 static PassOwnPtr<TextCodec> create(const TextEncoding&, const void*);
50 50
51 virtual String decode(const char*, size_t length, FlushBehavior, bool stopOn Error, bool& sawError) override; 51 String decode(const char*, size_t length, FlushBehavior, bool stopOnError, b ool& sawError) override;
52 virtual CString encode(const UChar*, size_t length, UnencodableHandling) ove rride; 52 CString encode(const UChar*, size_t length, UnencodableHandling) override;
53 virtual CString encode(const LChar*, size_t length, UnencodableHandling) ove rride; 53 CString encode(const LChar*, size_t length, UnencodableHandling) override;
54 54
55 template<typename CharType> 55 template<typename CharType>
56 CString encodeCommon(const CharType*, size_t length, UnencodableHandling); 56 CString encodeCommon(const CharType*, size_t length, UnencodableHandling);
57 CString encodeInternal(const TextCodecInput&, UnencodableHandling); 57 CString encodeInternal(const TextCodecInput&, UnencodableHandling);
58 58
59 void createICUConverter() const; 59 void createICUConverter() const;
60 void releaseICUConverter() const; 60 void releaseICUConverter() const;
61 #if defined(USING_SYSTEM_ICU) 61 #if defined(USING_SYSTEM_ICU)
62 bool needsGBKFallbacks() const { return m_needsGBKFallbacks; } 62 bool needsGBKFallbacks() const { return m_needsGBKFallbacks; }
63 void setNeedsGBKFallbacks(bool needsFallbacks) { m_needsGBKFallbacks = needs Fallbacks; } 63 void setNeedsGBKFallbacks(bool needsFallbacks) { m_needsGBKFallbacks = needs Fallbacks; }
(...skipping 14 matching lines...) Expand all
78 public: 78 public:
79 ICUConverterWrapper() : converter(0) { } 79 ICUConverterWrapper() : converter(0) { }
80 ~ICUConverterWrapper(); 80 ~ICUConverterWrapper();
81 81
82 UConverter* converter; 82 UConverter* converter;
83 }; 83 };
84 84
85 } // namespace WTF 85 } // namespace WTF
86 86
87 #endif // TextCodecICU_h 87 #endif // TextCodecICU_h
OLDNEW
« no previous file with comments | « Source/wtf/Uint8ClampedArray.h ('k') | Source/wtf/text/TextCodecLatin1.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698