Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1218293019: Fix virtual/override/final usage in Source/wtf/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/wtf/. - We should specify just one of them to a function. This was done by the following command. % sed -i "" -E "s/virtual (.*) final/\1 final/g; s/virtual (.*) override/\1 override/g; s/override final/final/g" <files> - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M Source/wtf/FilePrintStream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/Float32Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Float64Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Int16Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Int32Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Int8Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/TypedArrayBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Uint16Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Uint32Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Uint8Array.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Uint8ClampedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextCodecICU.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/wtf/text/TextCodecLatin1.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/text/TextCodecReplacement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextCodecUTF16.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/text/TextCodecUTF8.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/text/TextCodecUserDefined.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
yosin@, please review this.
5 years, 5 months ago (2015-07-08 03:45:21 UTC) #2
yosin_UTC9
lgtm
5 years, 5 months ago (2015-07-08 04:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218293019/1
5 years, 5 months ago (2015-07-08 04:55:31 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 04:59:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198463

Powered by Google App Engine
This is Rietveld 408576698