Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: Source/core/editing/CompositeEditCommand.h

Issue 1218293014: Fix virtual/override/final usage in Source/core/editing/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/CompositeEditCommand.h
diff --git a/Source/core/editing/CompositeEditCommand.h b/Source/core/editing/CompositeEditCommand.h
index 27d31faa15a2d42056700ff106fbe05b6d937234..f692062531e25ef3e72cd885f1b76433665c1d98 100644
--- a/Source/core/editing/CompositeEditCommand.h
+++ b/Source/core/editing/CompositeEditCommand.h
@@ -44,10 +44,10 @@ class EditCommandComposition final : public UndoStep {
public:
static PassRefPtrWillBeRawPtr<EditCommandComposition> create(Document*, const VisibleSelection&, const VisibleSelection&, EditAction);
- virtual bool belongsTo(const LocalFrame&) const override;
- virtual void unapply() override;
- virtual void reapply() override;
- virtual EditAction editingAction() const override { return m_editAction; }
+ bool belongsTo(const LocalFrame&) const override;
+ void unapply() override;
+ void reapply() override;
+ EditAction editingAction() const override { return m_editAction; }
void append(SimpleEditCommand*);
const VisibleSelection& startingSelection() const { return m_startingSelection; }
@@ -73,7 +73,7 @@ private:
class CompositeEditCommand : public EditCommand {
public:
- virtual ~CompositeEditCommand();
+ ~CompositeEditCommand() override;
void apply();
bool isFirstCommand(EditCommand* command) { return !m_commands.isEmpty() && m_commands.first() == command; }
@@ -170,7 +170,7 @@ protected:
WillBeHeapVector<RefPtrWillBeMember<EditCommand>> m_commands;
private:
- virtual bool isCompositeEditCommand() const override final { return true; }
+ bool isCompositeEditCommand() const final { return true; }
RefPtrWillBeMember<EditCommandComposition> m_composition;
};

Powered by Google App Engine
This is Rietveld 408576698