Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1218293014: Fix virtual/override/final usage in Source/core/editing/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, groby+blinkspell_chromium.org, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/core/editing/. - We should specify just one of them to a function. - Non-base virtual destructors should have |override| keywords. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198370

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -92 lines) Patch
M Source/core/editing/AppendNodeCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/CreateLinkCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/EditCommand.h View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/editing/EditingStyle.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/IndentOutdentCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertListCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertTextCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/MoveSelectionCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/RemoveFormatCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveNodeCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveNodePreservingChildrenCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SimplifyMarkupCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellCheckRequester.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/SplitElementCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/SplitTextNodeCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/SplitTextNodeContainingElementCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TypingCommand.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/editing/UnlinkCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tkent
yosin@, please take a look at this.
5 years, 5 months ago (2015-07-07 06:17:40 UTC) #2
yosin_UTC9
lgtm Thanks for clean up! It seems mac bot has trouble with running "isolate tests". ...
5 years, 5 months ago (2015-07-07 06:40:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218293014/1
5 years, 5 months ago (2015-07-07 06:40:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/69918)
5 years, 5 months ago (2015-07-07 06:55:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218293014/1
5 years, 5 months ago (2015-07-07 08:05:00 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:09:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198370

Powered by Google App Engine
This is Rietveld 408576698