Chromium Code Reviews| Index: base/file_version_info_unittest.cc |
| diff --git a/base/file_version_info_unittest.cc b/base/file_version_info_unittest.cc |
| index 9b10d04b9750200c5ece15cdb36f4a29ce818341..2a14ffc83e7d2621d73f270e902751970ab02099 100644 |
| --- a/base/file_version_info_unittest.cc |
| +++ b/base/file_version_info_unittest.cc |
| @@ -36,24 +36,24 @@ TEST(FileVersionInfoTest, HardCodedProperties) { |
| L"FileVersionInfoTest1.dll" |
| }; |
| - const wchar_t* kExpectedValues[1][15] = { |
| + const wchar_t* kExpectedValues[1][15] = {{ |
|
Nico
2015/07/01 18:40:48
nit: const wchar_t* const
dcheng
2015/07/01 21:26:38
Done.
dcheng
2015/07/01 21:26:38
Done.
|
| // FileVersionInfoTest.dll |
| - L"Goooooogle", // company_name |
| - L"Google", // company_short_name |
| - L"This is the product name", // product_name |
| - L"This is the product short name", // product_short_name |
| - L"The Internal Name", // internal_name |
| - L"4.3.2.1", // product_version |
| - L"Private build property", // private_build |
| - L"Special build property", // special_build |
| + L"Goooooogle", // company_name |
| + L"Google", // company_short_name |
| + L"This is the product name", // product_name |
| + L"This is the product short name", // product_short_name |
| + L"The Internal Name", // internal_name |
| + L"4.3.2.1", // product_version |
| + L"Private build property", // private_build |
| + L"Special build property", // special_build |
| L"This is a particularly interesting comment", // comments |
| - L"This is the original filename", // original_filename |
| - L"This is my file description", // file_description |
| - L"1.2.3.4", // file_version |
| - L"This is the legal copyright", // legal_copyright |
| - L"This is the legal trademarks", // legal_trademarks |
| - L"This is the last change", // last_change |
| - }; |
| + L"This is the original filename", // original_filename |
| + L"This is my file description", // file_description |
| + L"1.2.3.4", // file_version |
| + L"This is the legal copyright", // legal_copyright |
| + L"This is the legal trademarks", // legal_trademarks |
| + L"This is the last change", // last_change |
| + }}; |
| for (int i = 0; i < arraysize(kDLLNames); ++i) { |
|
Nico
2015/07/01 18:40:49
nit: Since arraysize(kDLLNames) is 1, maybe get ri
|
| FilePath dll_path = GetTestDataPath(); |