Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1218203002: Convert sandbox_mac_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert sandbox_mac_unittests to run exclusively on Swarming Also add gn_unittests_run to build/gn_migration.gypi, which I forgot in https://codereview.chromium.org/1214533005/ Also reshuffle build/gn_migration.gypi to use consistent conditionals. 0 configs already ran on Swarming 6 used to run locally and were converted: - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) Ran: ./manage.py --convert sandbox_mac_unittests BUG=98637 TBR=cpu Committed: https://crrev.com/92a101b6d732b8af7f12f19459e382181586373a Cr-Commit-Position: refs/heads/master@{#337057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -10 lines) Patch
M build/gn_migration.gypi View 3 chunks +16 lines, -10 lines 0 comments Download
M sandbox/mac/sandbox_mac.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
A sandbox/sandbox_mac_unittests.isolate View 1 chunk +10 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Nico
rsesek: sandbox/ maruel: testing/
5 years, 5 months ago (2015-07-01 04:56:14 UTC) #2
M-A Ruel
lgtm
5 years, 5 months ago (2015-07-01 14:33:31 UTC) #3
Robert Sesek
lgtm
5 years, 5 months ago (2015-07-01 17:19:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218203002/1
5 years, 5 months ago (2015-07-01 17:31:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/75380)
5 years, 5 months ago (2015-07-01 17:41:00 UTC) #8
Nico
tbr cpu for sandbox/owners (the isolate format forces us to put the isolate file into ...
5 years, 5 months ago (2015-07-01 17:48:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218203002/1
5 years, 5 months ago (2015-07-01 17:49:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 17:56:22 UTC) #13
cpu_(ooo_6.6-7.5)
homer: .... nico: thats good! homer: .. lgtm, can I go now?
5 years, 5 months ago (2015-07-01 17:56:52 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 17:58:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92a101b6d732b8af7f12f19459e382181586373a
Cr-Commit-Position: refs/heads/master@{#337057}

Powered by Google App Engine
This is Rietveld 408576698