Issue 12182002: Fix RenderTextTest.PangoAttributes test leaks; remove suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12182002: Fix RenderTextTest.PangoAttributes test leaks; remove suppressions. (Closed)

Created:
7 years, 10 months ago by msw

Modified:
7 years, 10 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix RenderTextTest.PangoAttributes test leaks; remove suppressions. I ran both tools locally to verify the leaks and my fixes. BUG=173597 TEST=No Valgrind or Heapcheck leaks detected in RenderTextTest.PangoAttributes. R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180275

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -39 lines)			Patch
M	tools/heapcheck/suppressions.txt	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	ui/gfx/render_text_unittest.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12182002/1

7 years, 10 months ago (2013-02-02 07:59:51 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106935

7 years, 10 months ago (2013-02-02 11:51:41 UTC) #4

commit-bot: I haz the power

7 years, 10 months ago (2013-02-02 19:49:46 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12182002/1

Expand Messages | Collapse Messages