Issue 1218183009: When syncing a child, we have to update the parent in all cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218183009: When syncing a child, we have to update the parent in all cases. (Closed)

Created:
5 years, 5 months ago by Hixie

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

When syncing a child, we have to update the parent in all cases. This: - Adds asserts all over the place to make sure things are working right with respect to the parent pointer. - Fixes the bugs those asserts uncovered. It turns out we were failing to update the parent pointer in a couple of cases: when the child hadn't changed (but the parent had), and when the node was replaced. - Remove the operator[] nonsense in scaffold. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a05bfef8096006056b2fff78092faf14d1319782

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -16 lines)			Patch
M	sky/sdk/example/widgets/sector.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/scaffold.dart	View	1	2 chunks	+10 lines, -12 lines	0 comments	Download
M	sky/sdk/lib/widgets/widget.dart	View	1	11 chunks	+26 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hixie

5 years, 5 months ago (2015-07-06 21:16:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a05bfef8096006056b2fff78092faf14d1319782 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages