Issue 1218173003: Add missing build dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218173003: Add missing build dependencies (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add missing build dependencies These dependencies will trigger a "gn check" violation in a future version of gn. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f2aa4c62e319e48c5cb1f499c6a721dddaf68c5f

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -0 lines)			Patch
M	mojo/dart/embedder/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	services/python/content_handler/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/bindings/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-01 15:28:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f2aa4c62e319e48c5cb1f499c6a721dddaf68c5f (presubmit successful).

Expand Messages | Collapse Messages