Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1218153005: Refactoring to support dark theme better (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix braces #

Patch Set 4 : fix tests #

Patch Set 5 : rebase and fix test #

Patch Set 6 : fix tests harder #

Patch Set 7 : fix button tests #

Patch Set 8 : fix tests another way #

Patch Set 9 : fix tests #

Patch Set 10 : hopefully fix last test #

Patch Set 11 : fix tests more #

Patch Set 12 : rebase #

Patch Set 13 : fix remaining tests #

Patch Set 14 : fix import issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -135 lines) Patch
M sky/sdk/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/example/stocks/lib/main.dart View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -7 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_home.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_settings.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +24 lines, -22 lines 0 comments Download
M sky/sdk/example/widgets/sector.dart View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M sky/sdk/example/widgets/styled_text.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/widgets/tabs.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/home.dart View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -5 lines 0 comments Download
M sky/sdk/lib/editing/input.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M sky/sdk/lib/theme/colors.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M sky/sdk/lib/theme/theme_data.dart View 1 2 3 4 5 6 7 8 9 10 1 chunk +60 lines, -22 lines 0 comments Download
M sky/sdk/lib/widgets/card.dart View 2 chunks +4 lines, -16 lines 0 comments Download
M sky/sdk/lib/widgets/checkbox.dart View 4 chunks +10 lines, -7 lines 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/drawer_header.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +27 lines, -8 lines 0 comments Download
M sky/sdk/lib/widgets/material_button.dart View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/radio.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +11 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +2 lines, -16 lines 0 comments Download
M sky/sdk/lib/widgets/switch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/tabs.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/examples/tabs-expected.txt View 1 2 3 4 5 6 7 8 9 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-01 00:02:42 UTC) #2
Hixie
I think you forgot to add a file? MaterialType isn't defined anywhere as far as ...
5 years, 5 months ago (2015-07-01 00:18:58 UTC) #3
jackson
On 2015/07/01 00:18:58, Hixie wrote: > I think you forgot to add a file? MaterialType ...
5 years, 5 months ago (2015-07-01 00:25:06 UTC) #4
jackson
5 years, 5 months ago (2015-07-06 15:05:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #14 (id:260001) manually as
d79da5276db27df0606d5ec933ec9887d2d0cb05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698