Issue 1218153004: Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218153004: Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (Closed)

Created:
5 years, 5 months ago by herb_g

Modified:
5 years, 5 months ago

Reviewers:
mtklein, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (patchset #1 id:1 of https://codereview.chromium.org/1213033003/) Reason for revert: Add tsan annotations to repair tests. Original issue's description: > Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. > > The ~ means "don't run this". This keeps all the other bots running the code, skipping it only on the whiny TSAN bot. > > BUG=skia:3997 > > Committed: https://skia.googlesource.com/skia/+/37cc0b2e31e4a078b12790253d7032d36271440c TBR=mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3997 Committed: https://skia.googlesource.com/skia/+/19fb80ed14efbe9762d417fe183def089fa7cb6c

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	tools/dm_flags.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	tools/dm_flags.py	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

herb_g

Created Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating.

5 years, 5 months ago (2015-06-30 21:23:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218153004/1

5 years, 5 months ago (2015-06-30 21:23:25 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-06-30 21:23:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19fb80ed14efbe9762d417fe183def089fa7cb6c