content/browser/renderer_host/pepper/pepper_file_io_host.cc - Issue 121813002: Pepper: Ensure FileIO host cleans up before FileSystem host destructs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_file_io_host.cc

Issue 121813002: Pepper: Ensure FileIO host cleans up before FileSystem host destructs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use Close message to ensure work is done before FileSystemHost dtor. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/pepper/pepper_file_io_host.cc

diff --git a/content/browser/renderer_host/pepper/pepper_file_io_host.cc b/content/browser/renderer_host/pepper/pepper_file_io_host.cc

index 6f7b55fd34ae3e37c36218c88fb8ecf9abeb675e..1118c584c94bc98f5d1d19169e051557de369aee 100644

--- a/content/browser/renderer_host/pepper/pepper_file_io_host.cc

+++ b/content/browser/renderer_host/pepper/pepper_file_io_host.cc

@@ -405,8 +405,10 @@ int32_t PepperFileIOHost::OnHostMsgFlush(

int32_t PepperFileIOHost::OnHostMsgClose(

ppapi::host::HostMessageContext* context) {

- if (check_quota_)

+ if (check_quota_) {

file_system_host_->CloseQuotaFile(this);

+ check_quota_ = false;

bbudge 2013/12/27 20:04:28 This ensures we don't do this twice.

+ }

if (file_ != base::kInvalidPlatformFileValue) {

base::FileUtilProxy::Close(

« no previous file with comments | « no previous file | ppapi/proxy/file_io_resource.h » ('j') | no next file with comments »