Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1218123003: Revert of [strong] Add tests for loading from proxy, super, with access checks (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
conradw, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [strong] Add tests for loading from proxy, super, with access checks (patchset #4 id:80001 of https://codereview.chromium.org/1193633003/) Reason for revert: [Sheriff] Breaks gc stress: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%202/builds/3968 Original issue's description: > [strong] Add tests for loading from proxy, super, with access checks > > Followup for https://codereview.chromium.org/1168093002/ > > These seem to already function correctly without the need for further runtime > changes. > > There will be a final follow-up for interceptors. > > BUG=v8:3956 > LOG=N > > Committed: https://crrev.com/ea4e568363f48955e7de6b538e559132e9899c86 > Cr-Commit-Position: refs/heads/master@{#29389} TBR=rossberg@chromium.org,conradw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Committed: https://crrev.com/365ff33234dc61e6454aa46b8d5d95c857b53d00 Cr-Commit-Position: refs/heads/master@{#29390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -357 lines) Patch
M test/cctest/test-api.cc View 1 chunk +0 lines, -158 lines 0 comments Download
M test/mjsunit/strong/load-builtins.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/strong/load-proxy.js View 1 chunk +0 lines, -96 lines 0 comments Download
D test/mjsunit/strong/load-super.js View 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [strong] Add tests for loading from proxy, super, with access checks
5 years, 5 months ago (2015-06-30 18:42:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218123003/1
5 years, 5 months ago (2015-06-30 18:42:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 18:42:45 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 18:43:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/365ff33234dc61e6454aa46b8d5d95c857b53d00
Cr-Commit-Position: refs/heads/master@{#29390}

Powered by Google App Engine
This is Rietveld 408576698