Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1218103005: [turbofan] Support cmp with shift/extend on ARM64. (Closed)

Created:
5 years, 5 months ago by martyn.capewell
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Support cmp with shift/extend on ARM64. Support 32-bit cmp with shift/extend by reusing the existing add/sub shift and extend code. Committed: https://crrev.com/1297a51e3024352ddb16e976bf4401551fa16ad5 Cr-Commit-Position: refs/heads/master@{#29435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -24 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 7 chunks +41 lines, -23 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +184 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
martyn.capewell
5 years, 5 months ago (2015-07-01 08:30:50 UTC) #2
Benedikt Meurer
LGTM.
5 years, 5 months ago (2015-07-02 04:09:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218103005/1
5 years, 5 months ago (2015-07-02 04:09:38 UTC) #5
commit-bot: I haz the power
The author martyn.capewell@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-02 04:09:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 04:32:07 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 04:32:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1297a51e3024352ddb16e976bf4401551fa16ad5
Cr-Commit-Position: refs/heads/master@{#29435}

Powered by Google App Engine
This is Rietveld 408576698