build/json_schema_bundle_compile.gypi - Issue 12181005: generated_api.h should have its body generated into generated_api.cc

Unified Diff: build/json_schema_bundle_compile.gypi

Issue 12181005: generated_api.h should have its body generated into generated_api.cc (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Latest master Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/json_schema_bundle_compile.gypi

diff --git a/build/json_schema_bundle_compile.gypi b/build/json_schema_bundle_compile.gypi

index e91f9d2771a8e4112a8bfc73066ecf0d71fed811..4b2c6d913a196146749561581a2ae21b5e89a73e 100644

--- a/build/json_schema_bundle_compile.gypi

+++ b/build/json_schema_bundle_compile.gypi

@@ -31,6 +31,7 @@

'outputs': [

'<(SHARED_INTERMEDIATE_DIR)/<(cc_dir)/generated_api.h',

+ '<(SHARED_INTERMEDIATE_DIR)/<(cc_dir)/generated_api.cc',

'<(SHARED_INTERMEDIATE_DIR)/<(cc_dir)/generated_schemas.h',

'<(SHARED_INTERMEDIATE_DIR)/<(cc_dir)/generated_schemas.cc',

@@ -56,6 +57,10 @@

'<(SHARED_INTERMEDIATE_DIR)',

]

+ 'dependencies': [

+ '<(DEPTH)/skia/skia.gyp:skia',

not at google - send to devlin 2013/02/10 16:03:44 why is this change needed?

Joe Thomas 2013/02/11 22:58:23 This is required to solve the header file dependen

not at google - send to devlin 2013/02/11 23:00:42 Hm, could you add the dependency where this rule i

+ '<(DEPTH)/sync/sync.gyp:sync_proto',

+ ],

# This target exports a hard dependency because it generates header

# files.

'hard_dependency': 1,

« no previous file with comments | « no previous file | tools/json_schema_compiler/code.py » ('j') | tools/json_schema_compiler/code.py » ('J')