tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py - Issue 1218073014: Migrate from telemetry PageSet -> StorySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py

Issue 1218073014: Migrate from telemetry PageSet -> StorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py

diff --git a/tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py b/tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py

index 7f4b7075ab8947734105dcad44f0678b0d817041..1f1814fd3c830d379f5c55439705bc9fac8b6e57 100644

--- a/tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py

+++ b/tools/chrome_proxy/live_tests/chrome_proxy_benchmark.py

@@ -10,7 +10,7 @@ from telemetry import benchmark

class ChromeProxyLatency(benchmark.Benchmark):

tag = 'latency'

test = measurements.ChromeProxyLatency

- page_set = pagesets.Top20PageSet

+ page_set = pagesets.Top20StorySet

@classmethod

def Name(cls):

@@ -20,7 +20,7 @@ class ChromeProxyLatency(benchmark.Benchmark):

class ChromeProxyLatencyDirect(benchmark.Benchmark):

tag = 'latency_direct'

test = measurements.ChromeProxyLatency

- page_set = pagesets.Top20PageSet

+ page_set = pagesets.Top20StorySet

@classmethod

def Name(cls):

@@ -30,7 +30,7 @@ class ChromeProxyLatencyDirect(benchmark.Benchmark):

class ChromeProxyDataSaving(benchmark.Benchmark):

tag = 'data_saving'

test = measurements.ChromeProxyDataSaving

- page_set = pagesets.Top20PageSet

+ page_set = pagesets.Top20StorySet

@classmethod

def Name(cls):

@@ -40,7 +40,7 @@ class ChromeProxyDataSaving(benchmark.Benchmark):

class ChromeProxyDataSavingDirect(benchmark.Benchmark):

tag = 'data_saving_direct'

test = measurements.ChromeProxyDataSaving

- page_set = pagesets.Top20PageSet

+ page_set = pagesets.Top20StorySet

@classmethod

def Name(cls):