tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py - Issue 1218073014: Migrate from telemetry PageSet -> StorySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py

Issue 1218073014: Migrate from telemetry PageSet -> StorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/exp_directive.py ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py

index a1ec2ca2aab4c963debaefc8ca741ff05b893012..8b3dc56acf824120d586f4e3641b37fe91d44db1 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py

@@ -3,7 +3,7 @@

# found in the LICENSE file.

from telemetry.page import page as page_module

-from telemetry.page import page_set as page_set_module

+from telemetry import story

class FallbackViaHeaderPage(page_module.Page):

@@ -12,11 +12,11 @@ class FallbackViaHeaderPage(page_module.Page):

super(FallbackViaHeaderPage, self).__init__(url=url, page_set=page_set)

-class FallbackViaHeaderPageSet(page_set_module.PageSet):

+class FallbackViaHeaderStorySet(story.StorySet):

""" Chrome proxy test sites """

def __init__(self):

- super(FallbackViaHeaderPageSet, self).__init__()

+ super(FallbackViaHeaderStorySet, self).__init__()

urls_list = [

'http://chromeproxy-test.appspot.com/default?respStatus=200',

@@ -24,4 +24,4 @@ class FallbackViaHeaderPageSet(page_set_module.PageSet):

]

for url in urls_list:

- self.AddUserStory(FallbackViaHeaderPage(url, self))

+ self.AddStory(FallbackViaHeaderPage(url, self))