tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py - Issue 1218073014: Migrate from telemetry PageSet -> StorySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py

Issue 1218073014: Migrate from telemetry PageSet -> StorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/exp_directive.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py

index c03d624d208f639cf210e445a6fa36cf8b2a9060..04c56f1611b0d422f277c3077fe0fbfbe47c9364 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py

@@ -3,7 +3,7 @@

# found in the LICENSE file.

from telemetry.page import page as page_module

-from telemetry.page import page_set as page_set_module

+from telemetry import story

class CorsBypassPage(page_module.Page):

@@ -12,16 +12,16 @@ class CorsBypassPage(page_module.Page):

super(CorsBypassPage, self).__init__(url=url, page_set=page_set)

-class CorsBypassPageSet(page_set_module.PageSet):

+class CorsBypassStorySet(story.StorySet):

""" Chrome proxy test sites """

def __init__(self):

- super(CorsBypassPageSet, self).__init__()

+ super(CorsBypassStorySet, self).__init__()

urls_list = [

'http://www.gstatic.com/chrome/googlezip/cors/',

]

for url in urls_list:

- self.AddUserStory(CorsBypassPage(url, self))

+ self.AddStory(CorsBypassPage(url, self))