tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py - Issue 1218073014: Migrate from telemetry PageSet -> StorySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

Issue 1218073014: Migrate from telemetry PageSet -> StorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/bypass.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

index ce3fd0da43208f5431251a5c07cd0381d63ea01a..07f0e0821f44c00ee60b9731f08168a3ada78d1d 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py

@@ -3,7 +3,7 @@

# found in the LICENSE file.

from telemetry.page import page as page_module

-from telemetry.page import page_set as page_set_module

+from telemetry import story

class BlockOncePage(page_module.Page):

@@ -31,12 +31,12 @@ class BlockOncePage(page_module.Page):

''')

action_runner.Wait(1)

-class BlockOncePageSet(page_set_module.PageSet):

+class BlockOnceStorySet(story.StorySet):

""" Chrome proxy test sites """

def __init__(self):

- super(BlockOncePageSet, self).__init__()

+ super(BlockOnceStorySet, self).__init__()

# Test block-once for a GET request.

urls_list = [

@@ -44,4 +44,4 @@ class BlockOncePageSet(page_set_module.PageSet):

]

for url in urls_list:

- self.AddUserStory(BlockOncePage(url, self))

+ self.AddStory(BlockOncePage(url, self))