sky/sdk/example/widgets/container.dart - Issue 1218023013: Hoist knowledge of image_cache into widgets/basic.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/example/widgets/container.dart

Issue 1218023013: Hoist knowledge of image_cache into widgets/basic.dart (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: address reviewer comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/example/widgets/container.dart

diff --git a/sky/sdk/example/widgets/container.dart b/sky/sdk/example/widgets/container.dart

index 1b99fe4c291cf98c3170f91ab7776cda50f6702d..9ebea3aa668b6d5166e6b574b37e343fee3036a3 100644

--- a/sky/sdk/example/widgets/container.dart

+++ b/sky/sdk/example/widgets/container.dart

@@ -14,7 +14,7 @@ class ContainerApp extends App {

padding: new EdgeDims.all(10.0),

margin: new EdgeDims.all(10.0),

decoration: new BoxDecoration(backgroundColor: const Color(0xFFCCCCCC)),

- child: new Image(

+ child: new NetworkImage(

src: "https://www.dartlang.org/logos/dart-logo.png",

size: new Size(300.0, 300.0)

)

« no previous file with comments | « no previous file | sky/sdk/lib/mojo/net/image_cache.dart » ('j') | no next file with comments »