Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: sky/sdk/lib/widgets/icon.dart

Issue 1218023013: Hoist knowledge of image_cache into widgets/basic.dart (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address reviewer comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/sdk/lib/widgets/basic.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'basic.dart'; 5 import 'basic.dart';
6 6
7 // TODO(eseidel): This should use package:. 7 // TODO(eseidel): This should use package:.
8 const String kAssetBase = '/packages/sky/assets/material-design-icons'; 8 const String kAssetBase = '/packages/sky/assets/material-design-icons';
9 9
10 class Icon extends Component { 10 class Icon extends Component {
(...skipping 11 matching lines...) Expand all
22 String category = ''; 22 String category = '';
23 String subtype = ''; 23 String subtype = '';
24 List<String> parts = type.split('/'); 24 List<String> parts = type.split('/');
25 if (parts.length == 2) { 25 if (parts.length == 2) {
26 category = parts[0]; 26 category = parts[0];
27 subtype = parts[1]; 27 subtype = parts[1];
28 } 28 }
29 // TODO(eseidel): This clearly isn't correct. Not sure what would be. 29 // TODO(eseidel): This clearly isn't correct. Not sure what would be.
30 // Should we use the ios images on ios? 30 // Should we use the ios images on ios?
31 String density = 'drawable-xxhdpi'; 31 String density = 'drawable-xxhdpi';
32 return new Image( 32 return new NetworkImage(
33 size: new Size(size.toDouble(), size.toDouble()), 33 size: new Size(size.toDouble(), size.toDouble()),
34 src: '${kAssetBase}/${category}/${density}/ic_${subtype}_${size}dp.png' 34 src: '${kAssetBase}/${category}/${density}/ic_${subtype}_${size}dp.png'
35 ); 35 );
36 } 36 }
37 37
38 } 38 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/widgets/basic.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698