Source/core/layout/LayoutBlock.cpp - Issue 1218023004: Fix a regression when position:static with absolute child changed to relative

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlock.cpp

Issue 1218023004: Fix a regression when position:static with absolute child changed to relative (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add ASSERT(gPositionedContainerMap->get(o)->size() == 1) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dynamic/static-to-relative-with-absolute-and-static-child-expected.html ('k') | Source/core/layout/LayoutObject.h » ('j') | Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutBlock.cpp

diff --git a/Source/core/layout/LayoutBlock.cpp b/Source/core/layout/LayoutBlock.cpp

index fc625dabc3bb795c86c022451ac44cb97e7b89b4..c5875358bdc3759972b26bd8048be8616888c1b9 100644

--- a/Source/core/layout/LayoutBlock.cpp

+++ b/Source/core/layout/LayoutBlock.cpp

@@ -287,7 +287,7 @@ void LayoutBlock::styleWillChange(StyleDifference diff, const ComputedStyle& new

} else if (!oldStyleIsContainer && (newStyle.position() != StaticPosition || newHasTransformRelatedProperty)) {

// Remove our absolutely positioned descendants from their current containing block.

// They will be inserted into our positioned objects list during layout.

- if (LayoutBlock* cb = containingBlock())

+ if (LayoutBlock* cb = containerForAbsolutePosition())

cb->removePositionedObjects(this, NewContainingBlock);

}

@@ -1512,6 +1512,7 @@ void LayoutBlock::insertPositionedObject(LayoutBox* o)

{

ASSERT(!isAnonymousBlock());

insertIntoTrackedLayoutBoxMaps(o, gPositionedDescendantsMap, gPositionedContainerMap);

+ ASSERT(gPositionedContainerMap->get(o)->size() == 1);

}

void LayoutBlock::removePositionedObject(LayoutBox* o)