Source/core/paint/BlockPainter.h - Issue 1218013003: Keep a cache of caret painters to avoid recomputing all the time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/BlockPainter.h

Issue 1218013003: Keep a cache of caret painters to avoid recomputing all the time. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: a shade of deduplication blue Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/paint/BlockPainter.h

diff --git a/Source/core/paint/BlockPainter.h b/Source/core/paint/BlockPainter.h

index b319a660b2a300e1a00fb10e5912437cf354f5cf..6e099ecc33e1bd070b0bc13a465c52594dba070c 100644

--- a/Source/core/paint/BlockPainter.h

+++ b/Source/core/paint/BlockPainter.h

@@ -15,6 +15,8 @@ class LayoutFlexibleBox;

class LayoutObject;

class LayoutPoint;

class LayoutRect;

+class LocalFrame;

+class PaintDataCache;

class BlockPainter {

public:

@@ -36,7 +38,7 @@ public:

private:

LayoutRect overflowRectForPaintRejection() const;

- bool hasCaret() const;

+ bool hasCaret(PaintDataCache* = nullptr) const;

void paintCarets(const PaintInfo&, const LayoutPoint&);

void paintContents(const PaintInfo&, const LayoutPoint&);

void paintSelection(const PaintInfo&, const LayoutPoint&);