Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 12180023: "Reverting 18090" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/systemhtml.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmlrenamer.py
diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py
index ff72aed060f508c46c5458cb76d7197cebf7ac35..69b90af774eeba75c651ee50d2b8362c2c2fc0c1 100644
--- a/tools/dom/scripts/htmlrenamer.py
+++ b/tools/dom/scripts/htmlrenamer.py
@@ -180,9 +180,7 @@ _private_html_members = monitored.Set('htmlrenamer._private_html_members', [
# Members from the standard dom that exist in the dart:html library with
# identical functionality but with cleaner names.
-renamed_html_members = monitored.Dict('htmlrenamer.renamed_html_members', {
- 'Document.createCDATASection': 'createCDataSection',
- 'Document.defaultView': 'window',
+_renamed_html_members = monitored.Dict('htmlrenamer._renamed_html_members', {
'DOMURL.createObjectURL': 'createObjectUrl',
'DOMURL.revokeObjectURL': 'revokeObjectUrl',
'DOMWindow.webkitConvertPointFromNodeToPage': 'convertPointFromNodeToPage',
@@ -192,6 +190,8 @@ renamed_html_members = monitored.Dict('htmlrenamer.renamed_html_members', {
'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl',
'DOMWindow.webkitRequestFileSystem': 'requestFileSystem',
'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl',
+ 'Document.createCDATASection': 'createCDataSection',
+ 'Document.defaultView': 'window',
'Element.scrollIntoViewIfNeeded': 'scrollIntoView',
'Element.webkitCreateShadowRoot': 'createShadowRoot',
'Element.webkitMatchesSelector' : 'matches',
@@ -509,17 +509,13 @@ class HtmlRenamer(object):
return None
name = self._FindMatch(interface, member, member_prefix,
- renamed_html_members)
+ _renamed_html_members)
- target_name = renamed_html_members[name] if name else member
+ target_name = _renamed_html_members[name] if name else member
if self._FindMatch(interface, member, member_prefix, _private_html_members):
if not target_name.startswith('$dom_'): # e.g. $dom_svgClassName
target_name = '$dom_' + target_name
- if not name and target_name.startswith('webkit'):
- target_name = member[len('webkit'):]
- target_name = target_name[:1].lower() + target_name[1:]
-
if dartify_name:
target_name = self._DartifyMemberName(target_name)
return target_name
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/systemhtml.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698