Fix Issue 8259: dart:math pow broken for large integers.

runtime/lib/double.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <math.h>
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/code_generator.h"  // DartModulo.
@@ skipping 61 matching lines @@
   return Double::New(left / right);
 }
 
 
 static RawInteger* DoubleToInteger(double val, const char* error_msg) {
   if (isinf(val) || isnan(val)) {
     const Array& args = Array::Handle(Array::New(1));
     args.SetAt(0, String::Handle(String::New(error_msg)));
     Exceptions::ThrowByType(Exceptions::kUnsupported, args);
   }
-  if ((Smi::kMinValue <= val) && (val <= Smi::kMaxValue)) {
-    return Smi::New(static_cast<intptr_t>(val));
-  } else if ((Mint::kMinValue <= val) && (val <= Mint::kMaxValue)) {
-    return Mint::New(static_cast<int64_t>(val));
+  const int64_t int64_val = static_cast<int64_t>(val);
+  // Check if overflow in double-to-int.
+  if ((int64_val == static_cast<int64_t>(0x8000000000000000LL)) &&

[Vyacheslav Egorov (Google), 2013/02/05 00:34:36]

I don't think we can do this.

If a truncated double is not representable in an integer then behavior is
undefined per C++ Standard. Thus we can't rely on it returning the same marker
as Intel instruction use. (see [conv.fpint] in the Standard)

Here is another idea: Mint/Smi::kMinValue is representable in a double and so is
Mint/Smi::kMaxValue + 1 (cause both are powers of two).

If you declare MaxValuePlusOneAsDouble constants then you should be able to use

(X::kMinValue <= val) && (val < X::kMaxValuePlusOneAsDouble) 

to determine whether result of a conversion fits into an X or not. 

+      ((val < -2.0) || (val > 0.0))) {
+    return BigintOperations::NewFromDouble(val);
+  } else if ((Smi::kMinValue <= int64_val) && (int64_val <= Smi::kMaxValue)) {
+    return Smi::New(static_cast<intptr_t>(int64_val));
   } else {
-    return BigintOperations::NewFromDouble(val);
+    ASSERT((Mint::kMinValue <= int64_val) && (int64_val <= Mint::kMaxValue));
+    return Mint::New(int64_val);
   }
 }
 
 DEFINE_NATIVE_ENTRY(Double_trunc_div, 2) {
   double left = Double::CheckedHandle(arguments->NativeArgAt(0)).value();
   GET_NON_NULL_NATIVE_ARGUMENT(Double, right_object, arguments->NativeArgAt(1));
   double right = right_object.value();
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Double_trunc_div %f ~/ %f\n", left, right);
   }
@@ skipping 224 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Double_getIsNegative, 1) {
   const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
   // Include negative zero, infinity.
   return Bool::Get(signbit(arg.value()) && !isnan(arg.value()));
 }
 
 // Add here only functions using/referring to old-style casts.
 
 }  // namespace dart