Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 12180016: Update pnacl/DEPS to bring in merge to r172453 (Closed)

Created:
7 years, 10 months ago by Derek Schuff
Modified:
7 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update pnacl/DEPS to bring in merge to r172453 There was one MIPS test failure introduced, I haven't made an attempt to debug it. R=jvoung@chromium.org,eliben@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3178 BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10714

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : update to corrected asm backends #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pnacl/DEPS View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M pnacl/scripts/lit_known_failures.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Derek Schuff
the current LLVM downtime is causing spurious build failures, and the recent mac buildbot xcode ...
7 years, 10 months ago (2013-02-05 00:14:05 UTC) #1
jvoung (off chromium)
On 2013/02/05 00:14:05, Derek Schuff wrote: > the current LLVM downtime is causing spurious build ...
7 years, 10 months ago (2013-02-05 17:01:55 UTC) #2
Derek Schuff
Ah, you are right, that's not necessary. On 2013/02/05 17:01:55, jvoung (cr) wrote: > On ...
7 years, 10 months ago (2013-02-05 17:12:12 UTC) #3
jvoung (off chromium)
otherwise LGTM On 2013/02/05 17:12:12, Derek Schuff wrote: > Ah, you are right, that's not ...
7 years, 10 months ago (2013-02-05 17:14:32 UTC) #4
petarj
@Derek The failing test for MIPS comes from different value for Data alignment factor in ...
7 years, 10 months ago (2013-02-07 00:15:45 UTC) #5
eliben
On 2013/02/07 00:15:45, petarj wrote: > @Derek > > The failing test for MIPS comes ...
7 years, 10 months ago (2013-02-07 00:25:15 UTC) #6
petarj
7 years, 10 months ago (2013-02-07 01:58:38 UTC) #7
Message was sent while issue was closed.
On 2013/02/07 00:25:15, eliben wrote:

The test (MC/Mips/ef_frame.ll) expects different value in Data alignment
factor.

Powered by Google App Engine
This is Rietveld 408576698