Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1217973003: [turbofan] Remove explicit context specialization from inlining. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove explicit context specialization from inlining. Ideally inliner itself should not deal with context specialization at all, since this is all handled in the pipeline instead (actually inlining already runs together with context specialization), and the inlining logic should not care about the specialization mode. R=jarin@chromium.org Committed: https://crrev.com/57267fef140750266bb030fc1adad51803ed7e15 Cr-Commit-Position: refs/heads/master@{#29366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/compiler/js-inlining.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-06-30 05:00:07 UTC) #1
Benedikt Meurer
Hey Jaro, This code is now obsolete, as inlining and context specialization run together in ...
5 years, 5 months ago (2015-06-30 05:00:56 UTC) #2
Jarin
lgtm
5 years, 5 months ago (2015-06-30 07:28:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217973003/1
5 years, 5 months ago (2015-06-30 07:33:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 07:37:25 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 07:37:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57267fef140750266bb030fc1adad51803ed7e15
Cr-Commit-Position: refs/heads/master@{#29366}

Powered by Google App Engine
This is Rietveld 408576698