Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: Source/core/frame/FrameView.h

Issue 1217943010: Add a FrameView lifecycle method that just updates layout, style and compositing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.h
diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h
index 5340a380b8154b9a30615ee8cfc91ccbcbdfaf6c..20725146c29d7c89d79bacbdca5b4da62c8d5398 100644
--- a/Source/core/frame/FrameView.h
+++ b/Source/core/frame/FrameView.h
@@ -227,7 +227,12 @@ public:
Color documentBackgroundColor() const;
- void updateLayoutAndStyleForPainting();
+ // Run all needed lifecycle stages. After calling this method, all frames will be in the lifecycle state PaintInvalidationClean.
+ void updateAllLifecyclePhases();
pdr. 2015/07/01 22:16:57 updateLifecycleToPaintInvalidationClean?
+
+ // Computes the style, layout and compositing lifecycle stages if needed. After calling this method, all frames wil lbe in a lifecycle
pdr. 2015/07/01 22:16:58 "wil lbe" -> "will be"
+ // state >= CompositingClean.
+ void updateLifecycleToCompositingClean();
bool invalidateViewportConstrainedObjects();
@@ -603,10 +608,10 @@ private:
virtual void setScrollOffset(const IntPoint&, ScrollType) override;
virtual void setScrollOffset(const DoublePoint&, ScrollType) override;
- void updateLayoutAndStyleForPaintingInternal();
+ void updateAllLifecyclePhasesInternal();
void invalidateTreeIfNeededRecursive();
void scrollContentsIfNeededRecursive();
- void updateLayoutAndStyleIfNeededRecursive();
+ void updateStyleAndLayoutIfNeededRecursive();
void reset();
void init();

Powered by Google App Engine
This is Rietveld 408576698