Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217943010: Add a FrameView lifecycle method that just updates layout, style and compositing. (Closed)

Created:
5 years, 5 months ago by chrishtr
Modified:
5 years, 5 months ago
Reviewers:
pdr., Xianzhu
CC:
aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, Rik, dglazkov+blink, dmazzoni, dshwang, krit, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, jchaffraix+rendering, je_julie, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a FrameView lifecycle method that just updates layout, style and compositing. Hit testing does not need all of the other lifecycle updates (see attached bug for details). BUG=501630 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198284

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -89 lines) Patch
M Source/core/css/AffectedByFocusTest.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingTestBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelectionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/GranularityStrategyTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 5 chunks +32 lines, -16 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElementTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DAPITest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/input/EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/input/EventHandlerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutPart.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTestHelper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/page/ContextMenuControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DisplayItemListPaintTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/TextPainterTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
chrishtr
https://codereview.chromium.org/1217943010/diff/20001/Source/core/layout/LayoutView.cpp File Source/core/layout/LayoutView.cpp (right): https://codereview.chromium.org/1217943010/diff/20001/Source/core/layout/LayoutView.cpp#newcode90 Source/core/layout/LayoutView.cpp:90: frameView()->updateLifecycleToCompositingClean(); This is the only caller of the new ...
5 years, 5 months ago (2015-07-01 21:44:58 UTC) #2
pdr.
https://codereview.chromium.org/1217943010/diff/20001/Source/core/frame/FrameView.h File Source/core/frame/FrameView.h (right): https://codereview.chromium.org/1217943010/diff/20001/Source/core/frame/FrameView.h#newcode231 Source/core/frame/FrameView.h:231: void updateAllLifecyclePhases(); updateLifecycleToPaintInvalidationClean? https://codereview.chromium.org/1217943010/diff/20001/Source/core/frame/FrameView.h#newcode233 Source/core/frame/FrameView.h:233: // Computes the style, ...
5 years, 5 months ago (2015-07-01 22:16:58 UTC) #4
pdr.
+wangxianzhu, please hold off on reviewing this just yet. Chrishtr pointed out that there's a ...
5 years, 5 months ago (2015-07-01 22:21:01 UTC) #5
chrishtr
Ready for review.
5 years, 5 months ago (2015-07-02 22:12:44 UTC) #6
Xianzhu
lgtm
5 years, 5 months ago (2015-07-03 20:05:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217943010/40001
5 years, 5 months ago (2015-07-03 20:06:17 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198284
5 years, 5 months ago (2015-07-03 21:23:34 UTC) #10
tapted
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1216543005/ by tapted@chromium.org. ...
5 years, 5 months ago (2015-07-06 03:43:27 UTC) #11
kochi
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1225583004/ by kochi@chromium.org. ...
5 years, 5 months ago (2015-07-06 03:47:12 UTC) #12
kochi
5 years, 5 months ago (2015-07-06 03:50:27 UTC) #13
Message was sent while issue was closed. 
On 2015/07/06 03:47:12, Takayoshi Kochi wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1225583004/ by mailto:kochi@chromium.org.
> 
> The reason for reverting is: This caused ChromeOS's browser_tests failures.
> 
> See http://crbug.com/507174..

This was http://crbug.com/507124.

Thanks tapted@ for reverting.  I was just a few minutes late.

Powered by Google App Engine
This is Rietveld 408576698