Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7016)

Unified Diff: Source/modules/fetch/FetchDataLoader.h

Issue 1217943007: Call Client methods synchronously in FetchDataLoader if the first read is Done or error (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix unittests. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/fetch/FetchDataLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/fetch/FetchDataLoader.h
diff --git a/Source/modules/fetch/FetchDataLoader.h b/Source/modules/fetch/FetchDataLoader.h
index bee7bf49d6e38f82c6d97f840ea15416d010c3ec..4c0525453f31a6f4de6de5d519665cfa9f18ceaa 100644
--- a/Source/modules/fetch/FetchDataLoader.h
+++ b/Source/modules/fetch/FetchDataLoader.h
@@ -23,6 +23,9 @@ namespace blink {
// on the thread where FetchDataLoader is created.
//
// - Client's methods can be called synchronously in start().
+// -- Specifically, if the first call by FetchDataLoader to read()/beginRead()
+// returns values other than Ok or ShouldWait,
+// Client's methods must be called synchronously in start().
// - If FetchDataLoader::cancel() is called (or FetchDataLoader is garbage
// collected), Client's methods are not called anymore.
// - FetchDataLoader takes the ownership of |handle|'s reader but not |handle|.
« no previous file with comments | « no previous file | Source/modules/fetch/FetchDataLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698