Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/objects-debug.cc

Issue 1217943004: Vector ICs: Introduce an InstanceType for the type feedback vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix for failing test. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/disasm.h" 7 #include "src/disasm.h"
8 #include "src/disassembler.h" 8 #include "src/disassembler.h"
9 #include "src/heap/objects-visiting.h" 9 #include "src/heap/objects-visiting.h"
10 #include "src/jsregexp.h" 10 #include "src/jsregexp.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 break; 60 break;
61 case FLOAT32X4_TYPE: 61 case FLOAT32X4_TYPE:
62 Float32x4::cast(this)->Float32x4Verify(); 62 Float32x4::cast(this)->Float32x4Verify();
63 break; 63 break;
64 case FIXED_ARRAY_TYPE: 64 case FIXED_ARRAY_TYPE:
65 FixedArray::cast(this)->FixedArrayVerify(); 65 FixedArray::cast(this)->FixedArrayVerify();
66 break; 66 break;
67 case FIXED_DOUBLE_ARRAY_TYPE: 67 case FIXED_DOUBLE_ARRAY_TYPE:
68 FixedDoubleArray::cast(this)->FixedDoubleArrayVerify(); 68 FixedDoubleArray::cast(this)->FixedDoubleArrayVerify();
69 break; 69 break;
70 case FEEDBACK_VECTOR_TYPE:
71 TypeFeedbackVector::cast(this)->TypeFeedbackVectorVerify();
72 break;
70 case BYTE_ARRAY_TYPE: 73 case BYTE_ARRAY_TYPE:
71 ByteArray::cast(this)->ByteArrayVerify(); 74 ByteArray::cast(this)->ByteArrayVerify();
72 break; 75 break;
73 case FREE_SPACE_TYPE: 76 case FREE_SPACE_TYPE:
74 FreeSpace::cast(this)->FreeSpaceVerify(); 77 FreeSpace::cast(this)->FreeSpaceVerify();
75 break; 78 break;
76 79
77 #define VERIFY_TYPED_ARRAY(Type, type, TYPE, ctype, size) \ 80 #define VERIFY_TYPED_ARRAY(Type, type, TYPE, ctype, size) \
78 case EXTERNAL_##TYPE##_ARRAY_TYPE: \ 81 case EXTERNAL_##TYPE##_ARRAY_TYPE: \
79 External##Type##Array::cast(this)->External##Type##ArrayVerify(); \ 82 External##Type##Array::cast(this)->External##Type##ArrayVerify(); \
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 V8_UINT64_C(0x7FF8000000000000); 398 V8_UINT64_C(0x7FF8000000000000);
396 // Create implementation specific sNaN by inverting relevant bit. 399 // Create implementation specific sNaN by inverting relevant bit.
397 unexpected ^= V8_UINT64_C(0x0008000000000000); 400 unexpected ^= V8_UINT64_C(0x0008000000000000);
398 CHECK((value & V8_UINT64_C(0x7FF8000000000000)) != unexpected || 401 CHECK((value & V8_UINT64_C(0x7FF8000000000000)) != unexpected ||
399 (value & V8_UINT64_C(0x0007FFFFFFFFFFFF)) == V8_UINT64_C(0)); 402 (value & V8_UINT64_C(0x0007FFFFFFFFFFFF)) == V8_UINT64_C(0));
400 } 403 }
401 } 404 }
402 } 405 }
403 406
404 407
408 void TypeFeedbackVector::TypeFeedbackVectorVerify() {
409 for (int i = 0; i < length(); i++) {
410 Object* e = get(i);
411 VerifyPointer(e);
412 }
413 }
414
415
405 void JSGeneratorObject::JSGeneratorObjectVerify() { 416 void JSGeneratorObject::JSGeneratorObjectVerify() {
406 // In an expression like "new g()", there can be a point where a generator 417 // In an expression like "new g()", there can be a point where a generator
407 // object is allocated but its fields are all undefined, as it hasn't yet been 418 // object is allocated but its fields are all undefined, as it hasn't yet been
408 // initialized by the generator. Hence these weak checks. 419 // initialized by the generator. Hence these weak checks.
409 VerifyObjectField(kFunctionOffset); 420 VerifyObjectField(kFunctionOffset);
410 VerifyObjectField(kContextOffset); 421 VerifyObjectField(kContextOffset);
411 VerifyObjectField(kReceiverOffset); 422 VerifyObjectField(kReceiverOffset);
412 VerifyObjectField(kOperandStackOffset); 423 VerifyObjectField(kOperandStackOffset);
413 VerifyObjectField(kContinuationOffset); 424 VerifyObjectField(kContinuationOffset);
414 } 425 }
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
1272 : it.rinfo()->target_object(); 1283 : it.rinfo()->target_object();
1273 CHECK(!CanLeak(target, heap, skip_weak_cell)); 1284 CHECK(!CanLeak(target, heap, skip_weak_cell));
1274 } 1285 }
1275 } 1286 }
1276 1287
1277 1288
1278 #endif // DEBUG 1289 #endif // DEBUG
1279 1290
1280 } // namespace internal 1291 } // namespace internal
1281 } // namespace v8 1292 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698