Mark localName() / prefix() / namespaceURI() virtual methods as FINAL

Mark localName() / prefix() / namespaceURI() virtual methods as FINAL

Mark localName() / prefix() / namespaceURI() virtual methods as FINAL in
Element as these are never overriden in Element subclasses. They have
different implementations in Attr and Element only, and the Attr class is
already marked as FINAL.

This increases the chances these methods are inlined by the compiler and
thus help with performance as these are hot in some benchmarks. Some callers
such as HTMLTagNodeList::nodeMatchesInlined() are hot and already know the
type is an Element at compile time.

R=adamk, abarth

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164380

[eseidel1, 2013-12-30 16:44:59]

Lgtm
On Dec 30, 2013 8:42 AM, <ch.dumez@samsung.com> wrote:

> Reviewers: abarth, adamk,
>
> Description:
> Mark localName() / prefix() / namespaceURI() virtual methods as FINAL
>
> Mark localName() / prefix() / namespaceURI() virtual methods as FINAL in
> Element as these are never overriden in Element subclasses. They have
> different implementations in Attr and Element only, and the Attr class is
> already marked as FINAL.
>
> This increases the chances these methods are inlined by the compiler and
> thus help with performance as these are hot in some benchmarks. Some
> callers
> such as HTMLTagNodeList::nodeMatchesInlined() are hot and already know the
> type is an Element at compile time.
>
> R=adamk, abarth
>
> Please review this at https://codereview.chromium.org/121793005/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+3, -3 lines):
>   M Source/core/dom/Element.h
>
>
> Index: Source/core/dom/Element.h
> diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
> index 8e14d196069971383361cdfa6ab374e207d31af1..
> 93c19895bae3aec6e8c7252425e8308a139affc4 100644
> --- a/Source/core/dom/Element.h
> +++ b/Source/core/dom/Element.h
> @@ -229,9 +229,9 @@ public:
>      bool hasLocalName(const AtomicString& other) const { return
> m_tagName.localName() == other; }
>      bool hasLocalName(const QualifiedName& other) const { return
> m_tagName.localName() == other.localName(); }
>
> -    virtual const AtomicString& localName() const OVERRIDE { return
> m_tagName.localName(); }
> -    virtual const AtomicString& prefix() const OVERRIDE { return
> m_tagName.prefix(); }
> -    virtual const AtomicString& namespaceURI() const OVERRIDE { return
> m_tagName.namespaceURI(); }
> +    virtual const AtomicString& localName() const OVERRIDE FINAL { return
> m_tagName.localName(); }
> +    virtual const AtomicString& prefix() const OVERRIDE FINAL { return
> m_tagName.prefix(); }
> +    virtual const AtomicString& namespaceURI() const OVERRIDE FINAL {
> return m_tagName.namespaceURI(); }
>
>      virtual KURL baseURI() const OVERRIDE FINAL;
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-30 16:47:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/121793005/1

[commit-bot: I haz the power, 2013-12-30 16:51:34]

Change committed as 164380