media/filters/video_renderer_base.cc - Issue 12179023: Sprinkle some CHECK()s in media::VideoRendererBase to help track down a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_base.cc

Issue 12179023: Sprinkle some CHECK()s in media::VideoRendererBase to help track down a crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/video_renderer_base.cc

diff --git a/media/filters/video_renderer_base.cc b/media/filters/video_renderer_base.cc

index 5a17940771120c543902274a13cf15f3011e43c5..8a78d07ed2efc44eb489aac6b4968dbc4ad42075 100644

--- a/media/filters/video_renderer_base.cc

+++ b/media/filters/video_renderer_base.cc

@@ -453,7 +453,8 @@ void VideoRendererBase::PutCurrentFrame(scoped_refptr<VideoFrame> frame) {

VideoRendererBase::~VideoRendererBase() {

base::AutoLock auto_lock(lock_);

- DCHECK(state_ == kUninitialized || state_ == kStopped) << state_;

+ CHECK(state_ == kUninitialized || state_ == kStopped) << state_;

+ CHECK_EQ(thread_, base::kNullThreadHandle);

}

void VideoRendererBase::FrameReady(VideoDecoder::Status status,

« no previous file with comments | « no previous file | no next file » | no next file with comments »