Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 12179013: Revert 180433 because build\some.gyp was added to the CL by mistake. (Closed)

Created:
7 years, 10 months ago by alexeypa (please no reviews)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Revert 180433 because build\some.gyp was added to the CL by mistake. > Merged all Chromoting Host code into remoting_core.dll (Windows). > > Consolidated all installable Chromoting Host core into remoting_core.dll and converted all executables into thin wrappers around entry points exposed by remoting_core.dll. This reduces size of the installer by approximately 600KB. > > This is the 3rd attempt to land this CL. The previous attempt was reverted at r179373 because ninja sometimes failed to create a manifest for targets that use manifestXXX linker flags. This CL fixes that by manually embedding the manifests into binaries. > > BUG=170200, 173052 > > Review URL: https://codereview.chromium.org/12092117 TBR=alexeypa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -866 lines) Patch
M build/some.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/branding_Chrome View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/branding_Chromium View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/continue_window_win.cc View 2 chunks +8 lines, -5 lines 0 comments Download
D remoting/host/desktop_process_main.h View 1 chunk +0 lines, -17 lines 0 comments Download
M remoting/host/desktop_process_main.cc View 5 chunks +46 lines, -50 lines 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/host_export.h View 1 chunk +0 lines, -24 lines 0 comments Download
A + remoting/host/host_ui.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/host_ui_resource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/host/installer/win/chromoting.wxs View 8 chunks +14 lines, -25 lines 0 comments Download
M remoting/host/installer/win/parameters.json View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/plugin/host_plugin.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + remoting/host/remoting_desktop.ver View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/remoting_host_me2me.ver View 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/host/remoting_me2me_host.h View 1 chunk +0 lines, -17 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 7 chunks +58 lines, -46 lines 0 comments Download
M remoting/host/verify_config_window_win.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/verify_config_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/video_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/win/core.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D remoting/host/win/core.rc View 1 chunk +0 lines, -90 lines 0 comments Download
D remoting/host/win/core_resource.h View 1 chunk +0 lines, -42 lines 0 comments Download
D remoting/host/win/daemon_process_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D remoting/host/win/daemon_process_main.h View 1 chunk +0 lines, -17 lines 0 comments Download
D remoting/host/win/daemon_process_main.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D remoting/host/win/desktop_process_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M remoting/host/win/elevated_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/host/win/elevated_controller.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/host/win/elevated_controller_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D remoting/host/win/elevated_controller_module.h View 1 chunk +0 lines, -17 lines 0 comments Download
M remoting/host/win/elevated_controller_module.cc View 4 chunks +12 lines, -10 lines 0 comments Download
A + remoting/host/win/elevated_controller_resource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/host/win/host_process_entry_point.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M remoting/host/win/host_service.cc View 5 chunks +62 lines, -1 line 0 comments Download
A + remoting/host/win/host_service.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/win/host_service_resource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/host/win/remoting_core.manifest View 1 chunk +0 lines, -8 lines 0 comments Download
D remoting/host/win/remoting_core.ver View 1 chunk +0 lines, -4 lines 0 comments Download
D remoting/host/win/remoting_desktop.manifest View 1 chunk +0 lines, -10 lines 0 comments Download
D remoting/host/win/remoting_desktop.ver View 1 chunk +0 lines, -4 lines 0 comments Download
D remoting/host/win/remoting_host.manifest View 1 chunk +0 lines, -10 lines 0 comments Download
D remoting/host/win/remoting_host.ver View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/remoting.gyp View 19 chunks +200 lines, -302 lines 0 comments Download
M remoting/version.rc.version View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
alexeypa (please no reviews)
7 years, 10 months ago (2013-02-04 17:17:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698