chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc - Issue 12179007: While screencasting a tab, do not disable rendering updates while hidden.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc

Issue 12179007: While screencasting a tab, do not disable rendering updates while hidden. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Finer-grained increment/decrement, per sky@'s comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc

diff --git a/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc b/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc

index a8e957bbe595821395ab870f54723e61b5583403..fa697d1ebce937e6100f9e6d693fe46abc6bc67d 100644

--- a/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc

+++ b/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc

@@ -435,9 +435,6 @@ void DraggedTabControllerGtk::Attach(TabStripGtk* attached_tabstrip,

drag_data_->get(i)->original_delegate_ = NULL;

}

- // Return the WebContents to normalcy.

- drag_data_->GetSourceWebContents()->SetCapturingContents(false);

sky 2013/02/05 01:43:20 How come you don't need calls to increment/decreme

// We need to ask the tabstrip we're attached to ensure that the ideal

// bounds for all its tabs are correctly generated, because the calculation

// in GetInsertionIndexForDraggedBounds needs them to be to figure out the

« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab_drag_controller.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')