Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 1217863006: Activate preserving of optimized code map accross GCs. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Activate preserving of optimized code map accross GCs. This enables --noflush-optimized-code-cache which allows preserving entries in the optimized code map accross GCs. This only applies to values being reachable through other paths. R=hpayer@chromium.org,hablich@chromium.org Committed: https://crrev.com/1a8776db25b63c4ce718423772d1fd13f58eeab5 Cr-Commit-Position: refs/heads/master@{#29755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
Michael Starzinger
Michael: This has the chance to bust a Canary because of bad interaction with the ...
5 years, 5 months ago (2015-07-03 09:58:45 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-07-03 13:00:13 UTC) #3
Michael Hablich
On 2015/07/03 13:00:13, Hannes Payer wrote: > lgtm Thanks for the heads-up. Let's ship this ...
5 years, 5 months ago (2015-07-03 13:22:24 UTC) #4
Michael Hablich
On 2015/07/03 at 13:22:24, Hablich wrote: > On 2015/07/03 13:00:13, Hannes Payer wrote: > > ...
5 years, 5 months ago (2015-07-16 12:54:24 UTC) #5
Michael Hablich
On 2015/07/16 at 12:54:24, Hablich wrote: > On 2015/07/03 at 13:22:24, Hablich wrote: > > ...
5 years, 5 months ago (2015-07-16 12:59:52 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217863006/1
5 years, 5 months ago (2015-07-20 13:53:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217863006/1
5 years, 5 months ago (2015-07-20 13:55:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 14:18:48 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a8776db25b63c4ce718423772d1fd13f58eeab5 Cr-Commit-Position: refs/heads/master@{#29755}
5 years, 5 months ago (2015-07-20 14:19:03 UTC) #13
Hannes Payer (out of office)
5 years, 4 months ago (2015-07-28 07:27:47 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1255043003/ by hpayer@chromium.org.

The reason for reverting is: This CL may be the reason for the spike on memory
corruption. Tentatively reverting this CL.

BUG=chromium:512780
LOG=n.

Powered by Google App Engine
This is Rietveld 408576698