media/midi/midi_manager_win.h - Issue 1217853007: Web MIDI: add a new UMA entry for the final result code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/midi_manager_win.h

Issue 1217853007: Web MIDI: add a new UMA entry for the final result code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add UMA Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/midi/midi_manager_win.h

diff --git a/media/midi/midi_manager_win.h b/media/midi/midi_manager_win.h

index f559841599385a0a57273dfa34b5b4424d27eb1c..dbee7e15a1791551953b73f6c2dbd53baeff516c 100644

--- a/media/midi/midi_manager_win.h

+++ b/media/midi/midi_manager_win.h

@@ -19,7 +19,7 @@ namespace midi {

class MidiServiceWinDelegate {

public:

virtual ~MidiServiceWinDelegate() {}

- virtual void OnCompleteInitialization(MidiResult result) = 0;

+ virtual void OnCompleteInitialization(Result result) = 0;

virtual void OnAddInputPort(MidiPortInfo info) = 0;

virtual void OnAddOutputPort(MidiPortInfo info) = 0;

virtual void OnSetInputPortState(uint32 port_index, MidiPortState state) = 0;

@@ -53,7 +53,7 @@ class MidiManagerWin final : public MidiManager, public MidiServiceWinDelegate {

double timestamp) final;

// MidiServiceWinDelegate overrides:

- void OnCompleteInitialization(MidiResult result) final;

+ void OnCompleteInitialization(Result result) final;

void OnAddInputPort(MidiPortInfo info) final;

void OnAddOutputPort(MidiPortInfo info) final;

void OnSetInputPortState(uint32 port_index, MidiPortState state) final;

« media/midi/midi_manager.cc ('K') | « media/midi/midi_manager_usb_unittest.cc ('k') | media/midi/midi_manager_win.cc » ('j') | media/midi/result.h » ('J')