content/common/media/midi_messages.h - Issue 1217853007: Web MIDI: add a new UMA entry for the final result code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/midi_messages.h

Issue 1217853007: Web MIDI: add a new UMA entry for the final result code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add UMA Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/media/midi_messages.h

diff --git a/content/common/media/midi_messages.h b/content/common/media/midi_messages.h

index 67500f60b68437fcfd7ee24700350e8937dca36f..14ac45d7f0a2c82b38b64825d8c0782b4ebccba3 100644

--- a/content/common/media/midi_messages.h

+++ b/content/common/media/midi_messages.h

@@ -10,7 +10,7 @@

#include "ipc/ipc_message_macros.h"

#include "ipc/param_traits_macros.h"

#include "media/midi/midi_port_info.h"

-#include "media/midi/midi_result.h"

+#include "media/midi/result.h"

#include "url/gurl.h"

#undef IPC_MESSAGE_EXPORT

@@ -28,8 +28,7 @@ IPC_STRUCT_TRAITS_BEGIN(media::midi::MidiPortInfo)

IPC_STRUCT_TRAITS_MEMBER(state)

IPC_STRUCT_TRAITS_END()

-IPC_ENUM_TRAITS_MAX_VALUE(media::midi::MidiResult,

- media::midi::MIDI_RESULT_LAST)

+IPC_ENUM_TRAITS_MAX_VALUE(media::midi::Result, media::midi::Result::MAX)

// Messages for IPC between MidiMessageFilter and MidiHost.

@@ -59,8 +58,7 @@ IPC_MESSAGE_CONTROL2(MidiMsg_SetOutputPortState,

uint32 /* port */,

media::midi::MidiPortState /* state */)

-IPC_MESSAGE_CONTROL1(MidiMsg_SessionStarted,

- media::midi::MidiResult /* result */)

+IPC_MESSAGE_CONTROL1(MidiMsg_SessionStarted, media::midi::Result /* result */)

IPC_MESSAGE_CONTROL3(MidiMsg_DataReceived,

uint32 /* port */,

« no previous file with comments | « content/browser/media/midi_host.cc ('k') | content/renderer/media/midi_message_filter.h » ('j') | media/midi/midi_manager.h » ('J')